IcyData

Starting investigation into the problem games logic in admin season dashboard.

Fix Implemented¶

Root Cause Identified:

The "Problem Games" section in the admin season dashboard was comparing game feature completion against all enabled features across all leagues, rather than just the features for the game's specific league.

Location:
app/controllers/api/v1/admin/seasons_controller.rb - find_problem_games method (lines 441-499)

The Bug:

Two places in the code were using Feature.enabled.count which counts all features:

1. Line 458 - Query to find incomplete games:

   .having("...", Feature.enabled.count)  # Wrong: counts ALL features
   

2. Lines 481-486 - Issue detection logic:

   total_features = Feature.enabled.count  # Wrong: counts ALL features
   if completed_features < total_features
     issues << "incomplete_features"
   end
   

Why This Caused False Positives:

Features are league-specific (NHL has 9 features, PWHL has 2 features):

• Before fix: PWHL games with 2/2 features completed were compared against 11 total features (9 NHL + 2 PWHL)
• Result: PWHL games incorrectly flagged as incomplete (2 < 11) ❌

Solution Implemented:

Changed both locations to use league-specific feature counts:

1. Lines 454-468 - Iterate through games and check against league features:

   incomplete_game_ids = []
   final_games.includes(:league).find_each do |game|
     next unless game.league
     
     expected_features = Feature.enabled.for_league(game.league).count
     completed_features = game.game_features.where(status: "completed").count
     
     if completed_features < expected_features
       incomplete_game_ids << game.id
     end
   end
   

2. Lines 485-492 - Use league-specific comparison:

   if game.final? && game.league
     completed_features = game.game_features.where(status: "completed").count
     expected_features = Feature.enabled.for_league(game.league).count  # Fixed!
     if completed_features < expected_features
       issues << "incomplete_features"
     end
   end
   

Testing Results:

✅ PWHL game: 2/2 features completed → NOT flagged as incomplete (correct!)
✅ NHL game: 9/9 features completed → NOT flagged as incomplete (correct!)

Files Modified:

• app/controllers/api/v1/admin/seasons_controller.rb - Fixed find_problem_games method

Impact:

• False positives eliminated
• Dashboard now accurately reflects game completion status
• Games only checked against their league's features
• Admin can now trust the "Problem Games" section for monitoring